Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for event listener #25

Closed
thbley opened this issue Dec 23, 2023 · 1 comment
Closed

Documentation for event listener #25

thbley opened this issue Dec 23, 2023 · 1 comment

Comments

@thbley
Copy link

thbley commented Dec 23, 2023

Describe the bug
document.body.addEventListener() should be document.addEventListener() in README.md ?

To Reproduce

README.md has:
document.body.addEventListener('pinecone-start', () => NProgress.start());
document.body.addEventListener('pinecone-end', () => NProgress.done());

index.ts has:
const startLoading = () => {
document.dispatchEvent(PineconeRouter.loadStart)
...
const endLoading = () => {
document.dispatchEvent(PineconeRouter.loadEnd)

@rehhouari
Copy link
Member

Wow issues close automatically when you reference it in a pull request!
Thanks for submitting this I missed it when I was updating!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants