Merge pull request rails#5525 from kennyj/fix_5411

Fix GH rails#5411. When precompiling, params method is undefined.
pinetops · Mar 22, 2012 · b714140 · b714140
2 parents 89f8866 + 8c262f7
commit b714140
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/actionpack/lib/sprockets/helpers/rails_helper.rb b/actionpack/lib/sprockets/helpers/rails_helper.rb
@@ -81,7 +81,7 @@ def stylesheet_path(source)
     private
       def debug_assets?
         compile_assets? && (Rails.application.config.assets.debug || params[:debug_assets])
-      rescue NoMethodError
+      rescue NameError
         false
       end
 

diff --git a/railties/test/application/assets_test.rb b/railties/test/application/assets_test.rb
@@ -492,6 +492,18 @@ class ::PostsController < ActionController::Base; end
       assert_match 'src="/sub/uri/assets/rails.png"', File.read("#{app_path}/public/assets/app.js")
     end
 
+    test "html assets are compiled when executing precompile" do
+      app_file "app/assets/pages/page.html.erb", "<%= javascript_include_tag :application %>"
+      ENV["RAILS_ENV"]   = "production"
+      ENV["RAILS_GROUP"] = "assets"
+
+      quietly do
+        Dir.chdir(app_path){ `bundle exec rake assets:precompile` }
+      end
+
+      assert File.exists?("#{app_path}/public/assets/page.html")
+    end
+
     private
 
     def app_with_assets_in_view