Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On software upgrade proposal page, time left till upgrade is wrong #553

Open
freak12techno opened this issue Mar 10, 2024 · 2 comments
Open

Comments

@freak12techno
Copy link
Contributor

Example: on Jackal latest chain upgrade proposal: https://ping.pub/jackal/gov/12
изображение
It says "in 7 hours" next to the "Upgrade plan", which is wrong, as it's more than 1 day.
It shows the correct time left till the upgrade below the "Upgrade plan" though.

Guess this line https://github.com/ping-pub/explorer/blob/master/src/modules/%5Bchain%5D/gov/%5Bproposal_id%5D.vue#L375 should be updated to use the upgrade time itself rather than the voting end time.

@liangping
Copy link
Member

it highly depends on blocktimes. here might used the 6s, that's why it's not accurate.

@freak12techno
Copy link
Contributor Author

@liangping yes, I mean it displays the correct data under the "Upgrade plan" block (1 days 13 hours 56 minutes 10 seconds), but wrong estimate (in 7 hours) on the right from "Upgrade plan" block

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants