Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Test Version - 7fc49ba #6

Closed
ping opened this issue Aug 5, 2023 · 11 comments
Closed

New Test Version - 7fc49ba #6

ping opened this issue Aug 5, 2023 · 11 comments

Comments

@ping
Copy link
Owner

ping commented Aug 5, 2023

overdrive-libby-plugin-7fc49ba.zip

Changes from last release:

  • New: Search tab that provides a basic search function across your libraries
  • New: Cards tab that gives an overview of your linked cards
  • New: Display number of available holds in the Holds tab text
  • New: Last used tab will be opened by default
  • New: Disable borrow button if limits for the card has been reached
  • New: Compatible with calibre 5.34.0 and newer
  • Improvement: Display hold wait information in status bar
  • Improvement: Try to reduce the amount of sensitive data logged
  • Improvement: Handle unexpected errors explicitly so that errors popups don't end up behind plugin UI
  • Fix: Holds view default sort
  • Fix: Display of loans that are due soon

cards

search

settings

@ping ping pinned this issue Aug 5, 2023
@ping ping mentioned this issue Aug 5, 2023
@p1nkyy
Copy link

p1nkyy commented Aug 8, 2023

Error that I encountered today. If you could enlighten me as to what happened. Did I hammer it too much?

calibre, version 6.24.0
ERROR: Unhandled exception: <b>ClientUnauthorisedError</b>: Failed to borrow book

calibre 6.24  embedded-python: True
Windows-10-10.0.19045-SP0 Windows ('64bit', 'WindowsPE')
('Windows', '10', '10.0.19045')
Python 3.10.1
Windows: ('10', '10.0.19045', 'SP0', 'Multiprocessor Free')
Interface language: None
Successfully initialized third party plugins: ACSM Input (0, 1, 0) && DeDRM (10, 0, 3) && ACSM Input Plugin GUI Extension (0, 1, 0) && KindleUnpack - The Plugin (0, 83, 1) && Modify ePub (1, 8, 1) && OverDrive Libby (0, 1, 6)
Traceback (most recent call last):
  File "calibre_plugins.overdrive_libby.libby.client", line 463, in send_request
  File "urllib\request.py", line 525, in open
  File "urllib\request.py", line 634, in http_response
  File "urllib\request.py", line 563, in error
  File "urllib\request.py", line 496, in _call_chain
  File "urllib\request.py", line 643, in http_error_default
urllib.error.HTTPError: HTTP Error 401: Unauthorized

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "calibre\gui2\threaded_jobs.py", line 82, in start_work
  File "calibre_plugins.overdrive_libby.borrow_book", line 36, in __call__
  File "calibre_plugins.overdrive_libby.libby.client", line 852, in borrow_hold
  File "calibre_plugins.overdrive_libby.libby.client", line 829, in borrow_title
  File "calibre_plugins.overdrive_libby.libby.client", line 488, in send_request
  File "calibre_plugins.overdrive_libby.libby.errors", line 138, in process
calibre_plugins.overdrive_libby.libby.errors.ClientUnauthorisedError: <calibre_plugins.overdrive_libby.libby.errors.ClientUnauthorisedError; http_status=401, msg='HTTP Error 401: Unauthorized', error_response='{"result":"unauthorized"}''

@ping
Copy link
Owner Author

ping commented Aug 8, 2023

I've seen this when the card needs to be verified.

@p1nkyy
Copy link

p1nkyy commented Aug 8, 2023

I've seen this when the card needs to be verified.

Trying to re-borrow the book works but OK thanks for feedback.

@ping
Copy link
Owner Author

ping commented Aug 8, 2023

I've seen this when the card needs to be verified.

Trying to re-borrow the book works but OK thanks for feedback.

Did you re-borrow from within the plugin or elsewhere?

@p1nkyy
Copy link

p1nkyy commented Aug 8, 2023

Within the plugin. BTW if this convo is unrelated feel free to delete all the comments. Thank you & apologies.

@p1nkyy
Copy link

p1nkyy commented Aug 10, 2023

image

Hi today when I open my Holds tab, it froze, the Error dialogue is flickering a bit, and Calibre then closed by itself. Happened every time I open the plugin.
EDIT: log sent in Mobileforum

@ping
Copy link
Owner Author

ping commented Aug 10, 2023

Hi today when I open my Holds tab, it froze, the Error dialogue is flickering a bit, and Calibre then closed by itself. Happened every time I open the plugin. EDIT: log sent in Mobileforum

f39a291 should fix this issue. You can download the fixed plugin zip from https://github.com/ping/libby-calibre-plugin/actions/runs/5817743004

@p1nkyy
Copy link

p1nkyy commented Aug 10, 2023

It works now, thank you.

@p1nkyy
Copy link

p1nkyy commented Aug 11, 2023

Some questions:

  1. What does the plugin do if a book with the same title has existed in Calibre and I borrowed another one from the plugin? Will it borrow the book? Will it notify me of duplicates?
  2. When I deleted a title manually from my Calibre, does it disappear from the plugin's loan list?
  3. Why does the status bar (showing loans, holds, cards) disappear after a short period of time?
    Thank you.

@ping
Copy link
Owner Author

ping commented Aug 11, 2023

1. What does the plugin do if a book with the same title has existed in Calibre and I borrowed another one from the plugin? Will it borrow the book? Will it notify me of duplicates?

There are no checks during borrowing. If you clicked borrow, the plugin will try to borrow. Broadly speaking, the plugin does not prevent you from doing anything unless Libby doesn't allow it.

There is some matching done during downloading. If a matched empty book exists, the loan will be downloaded as a new format for the existing book (unless "Always download as a new book" is enabled in setup). Otherwise, the loan will always be downloaded as a new book, duplicate or not.

2. When I deleted a title manually from my Calibre, does it disappear from the plugin's loan list?

No. You have to return the loan yourself or wait for the loan to expire.

3. Why does the status bar (showing loans, holds, cards) disappear after a short period of time?

No particular reason, I just prefer it that way because it looks less cluttered. The only time a message stays in the statusbar is if it's about an error. Otherwise it always disappears after a while.

@ping ping unpinned this issue Aug 11, 2023
@ping
Copy link
Owner Author

ping commented Aug 11, 2023

Superseded by #7

@ping ping closed this as completed Aug 11, 2023
Repository owner locked as resolved and limited conversation to collaborators Aug 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants