New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Gzip Support for uiserver #514
Conversation
Signed-off-by: niedhui <niedhui@gmail.com>
Thanks for your pull request. Pick up issue #480 and reopen this PR |
Thanks for your contribution. If your PR get merged, you will be rewarded 605 points. |
@@ -38,3 +42,52 @@ func Handler() http.Handler { | |||
func AssetFS() *assetfs.AssetFS { | |||
return fs | |||
} | |||
|
|||
type gzipHandler struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! There is a similar server in PD as well. Could you figure out some way so that code can be reused? https://github.com/pingcap/pd/blob/master/pkg/dashboard/uiserver/uiserver.go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rest LGTM, verified it works
Signed-off-by: niedhui <niedhui@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool! I'm merging this PR. Could you also propose a PR in PD as well?
UCP #508