New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor tiup list subcommand to use v1 repository #258
Conversation
please fix resolve conflicts and fix the tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly looks good, a few comments inline.
Signed-off-by: lucklove <gnu.crazier@gmail.com>
c8415e0
to
dc74671
Compare
Signed-off-by: lucklove <gnu.crazier@gmail.com>
Signed-off-by: lucklove <gnu.crazier@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some suggestions inline, but nothing blocking
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's better to sort the result to make the result stable.
Co-authored-by: Nick Cameron <nrc@ncameron.org>
Co-authored-by: Lonng <heng@lonng.org>
Signed-off-by: lucklove <gnu.crazier@gmail.com>
Signed-off-by: lucklove <gnu.crazier@gmail.com>
Signed-off-by: lucklove <gnu.crazier@gmail.com>
@lucklove
|
Signed-off-by: lucklove <gnu.crazier@gmail.com>
Signed-off-by: lucklove <gnu.crazier@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #258 +/- ##
=======================================
Coverage 23.89% 23.89%
=======================================
Files 36 36
Lines 2921 2921
=======================================
Hits 698 698
Misses 2130 2130
Partials 93 93 Continue to review full report at Codecov.
|
What problem does this PR solve?
Switch repository from v0 to V1
What is changed and how it works?
Use env.V1Repository instead of env.Repository
Check List
Tests
Code changes
Side effects
Related changes