Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor tiup list subcommand to use v1 repository #258

Merged
merged 12 commits into from May 26, 2020

Conversation

lucklove
Copy link
Member

What problem does this PR solve?

Switch repository from v0 to V1

What is changed and how it works?

Use env.V1Repository instead of env.Repository

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Code changes

Side effects

Related changes

@july2993
Copy link
Contributor

please fix resolve conflicts and fix the tests

Copy link
Contributor

@nrc nrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good, a few comments inline.

cmd/list.go Outdated Show resolved Hide resolved
pkg/repository/v1manifest/index.go Outdated Show resolved Hide resolved
pkg/repository/v1manifest/component.go Outdated Show resolved Hide resolved
pkg/repository/v1manifest/types.go Outdated Show resolved Hide resolved
pkg/repository/v1manifest/version.go Outdated Show resolved Hide resolved
@nrc nrc mentioned this pull request May 25, 2020
13 tasks
Signed-off-by: lucklove <gnu.crazier@gmail.com>
@lucklove lucklove force-pushed the install branch 2 times, most recently from c8415e0 to dc74671 Compare May 26, 2020 04:34
Signed-off-by: lucklove <gnu.crazier@gmail.com>
pkg/meta/meta.go Outdated Show resolved Hide resolved
Signed-off-by: lucklove <gnu.crazier@gmail.com>
Copy link
Contributor

@nrc nrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some suggestions inline, but nothing blocking

cmd/list.go Show resolved Hide resolved
cmd/list.go Show resolved Hide resolved
cmd/list.go Outdated Show resolved Hide resolved
cmd/list.go Outdated Show resolved Hide resolved
Copy link
Contributor

@lonng lonng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better to sort the result to make the result stable.

lucklove and others added 5 commits May 26, 2020 15:21
Co-authored-by: Nick Cameron <nrc@ncameron.org>
Co-authored-by: Lonng <heng@lonng.org>
Signed-off-by: lucklove <gnu.crazier@gmail.com>
Signed-off-by: lucklove <gnu.crazier@gmail.com>
Signed-off-by: lucklove <gnu.crazier@gmail.com>
@july2993
Copy link
Contributor

@lucklove
pls fix ci (maybe just run go mod tidy)

[2020-05-26T10:37:09.602Z] go: extracting gopkg.in/fsnotify.v1 v1.4.7

[2020-05-26T10:37:09.602Z] go: downloading github.com/fsnotify/fsnotify v1.4.7

[2020-05-26T10:37:09.602Z] go: extracting github.com/fsnotify/fsnotify v1.4.7

[2020-05-26T10:37:09.602Z] go: extracting github.com/facebookgo/subset v0.0.0-20200203212716-c811ad88dec4

[2020-05-26T10:37:09.603Z] go: extracting github.com/chzyer/logex v1.1.10

[2020-05-26T10:37:09.603Z] go: extracting golang.org/x/text v0.3.2

[2020-05-26T10:37:10.168Z] Files go.sum and /tmp/go.sum.before differ

[2020-05-26T10:37:10.168Z] make: *** [tidy] Error 1

[2020-05-26T10:37:10.168Z] + set +x

[2020-05-26T10:37:10.168Z] GO111MODULE=off go get github.com/wadey/gocovmerge

[2020-05-26T10:37:25.168Z] gocovmerge cover/cov.* | grep -vE ".*.pb.go|.*__failpoint_binding__.go|mock.go" > "cover/all_cov.out"

[2020-05-26T10:37:25.168Z] bash: cover/all_cov.out: No such file or directory

[2020-05-26T10:37:25.168Z] 2020/05/26 18:37:23 failed to parse profiles: open cover/cov.*: no such file or directory

[2020-05-26T10:37:25.168Z] make: *** [coverage] Error 1

script returned exit code 2

Signed-off-by: lucklove <gnu.crazier@gmail.com>
@codecov-commenter
Copy link

Codecov Report

Merging #258 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #258   +/-   ##
=======================================
  Coverage   23.89%   23.89%           
=======================================
  Files          36       36           
  Lines        2921     2921           
=======================================
  Hits          698      698           
  Misses       2130     2130           
  Partials       93       93           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c5ebde...21314ed. Read the comment docs.

@lucklove lucklove merged commit 49f7781 into pingcap:master May 26, 2020
@lonng lonng added this to Done in SIG TiUP Kanban May 28, 2020
@siddontang siddontang removed this from Done in SIG TiUP Kanban Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants