Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize parser performance #1373

Open
xingyong opened this issue Apr 26, 2022 · 1 comment
Open

Optimize parser performance #1373

xingyong opened this issue Apr 26, 2022 · 1 comment

Comments

@xingyong
Copy link

Bug Report

Please answer these questions before submitting your issue. Thanks!

  1. What did you do?
    If possible, provide a recipe for reproducing the error.
    financeaccount.zip
    in the attachment,use the go tool pprof profile,will see parser.New() is too hot because of slice allocation.
    image
    Maybe, a object pool is proper.

  2. What did you expect to see?
    Reduce the overhead of make slice

  3. What did you see instead?
    parser.New() is too hot

  4. What version of TiDB SQL Parser are you using?
    master, all versions

@tangenta
Copy link
Contributor

The parser instance is expected to be reused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants