Skip to content

Commit

Permalink
Merge 41cbe75 into 04170fa
Browse files Browse the repository at this point in the history
  • Loading branch information
nolouch committed Dec 27, 2018
2 parents 04170fa + 41cbe75 commit 358a6c9
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 4 deletions.
9 changes: 6 additions & 3 deletions server/leader.go
Original file line number Diff line number Diff line change
Expand Up @@ -310,14 +310,17 @@ func (s *Server) watchLeader(leader *pdpb.Member, revision int64) {
defer s.cluster.regionSyncer.StopSyncWithLeader()
}

// The revision is the revision of last modification on this key.
// If the revision is compacted, will meet required revision has been compacted error.
// In this case, use the compact revision to re-watch the key.
for {
// gofail: var delayWatcher struct{}
rch := watcher.Watch(ctx, s.getLeaderPath(), clientv3.WithRev(revision))
for wresp := range rch {
// meet compacted error, use current revision.
// meet compacted error, use the compact revision.
if wresp.CompactRevision != 0 {
log.Warnf("required revision %d has been compacted, use current revision", revision)
revision = 0
log.Warnf("required revision %d has been compacted, use the compact revision %d", revision, wresp.CompactRevision)
revision = wresp.CompactRevision
break
}
if wresp.Canceled {
Expand Down
2 changes: 1 addition & 1 deletion tests/server/leader_watch_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ import (

func (s *serverTestSuite) TestWatcher(c *C) {
c.Parallel()
cluster, err := tests.NewTestCluster(1)
cluster, err := tests.NewTestCluster(1, func(conf *server.Config) { conf.AutoCompactionRetention = "1s" })
c.Assert(err, IsNil)
defer cluster.Destroy()

Expand Down

0 comments on commit 358a6c9

Please sign in to comment.