Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

placement rule does not try to promote learner to voter to match rules #2419

Closed
disksing opened this issue May 14, 2020 · 0 comments · Fixed by #2546
Closed

placement rule does not try to promote learner to voter to match rules #2419

disksing opened this issue May 14, 2020 · 0 comments · Fixed by #2546
Assignees
@disksing
Labels
priority/release-blocker The issue will make release block. type/bug The issue is confirmed as a bug.
Projects
Questions and Bug Reports SIG Scheduling Kanban
Milestone
v4.0.2

Comments

@disksing
Copy link
Contributor

For example, the rule is 3 voters, and the peers are voter + voter + offline voter + learner. PD will try to replace the offline voter first, but there is no valid store. The correct schedule is to promote the learner then remove the offline voter.
@disksing disksing added the type/bug The issue is confirmed as a bug. label May 14, 2020
@disksing disksing self-assigned this May 14, 2020
@github-actions github-actions bot added this to Need Triage in Questions and Bug Reports May 14, 2020
@disksing disksing added this to To do in Placement Rules May 14, 2020
@rleungx rleungx moved this from Need Triage to Need Fix in Questions and Bug Reports May 14, 2020
@nolouch nolouch removed this from To do in Placement Rules Jun 3, 2020
@nolouch nolouch moved this from Need Fix to Fix: High Priority in Questions and Bug Reports Jun 3, 2020
@nolouch nolouch added this to the v4.0.2 milestone Jun 17, 2020
@disksing disksing mentioned this issue Jun 17, 2020
Merged
@HunDunDM HunDunDM added the priority/release-blocker The issue will make release block. label Jun 17, 2020
This was referenced Jun 18, 2020
Merged
Merged
@JmPotato JmPotato moved this from Fix: High Priority to Closed in Questions and Bug Reports Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@disksing disksing

Labels
priority/release-blocker The issue will make release block. type/bug The issue is confirmed as a bug.
Projects
Questions and Bug Reports
  
Closed
SIG Scheduling Kanban
  
Awaiting triage
Milestone
v4.0.2
Development

Successfully merging a pull request may close this issue.

rule checker: try to remove orphan peer after fix rule peers oh-my-tidb/pd
3 participants
@nolouch @disksing @HunDunDM