Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simulator: add nodes dynamically in the simulator #1202

Merged
merged 2 commits into from Aug 17, 2018

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Aug 16, 2018

What have you changed? (required)

This PR adds a case to dynamically add nodes in the simulator and does slightly cleanup.

What are the type of the changes (required)?

  • Improvement (non-breaking change which is an improvement to an existing feature)

How has this PR been tested (required)?

  • Manual tests

@disksing
Copy link
Contributor

PTAL @nolouch

Copy link
Contributor

@nolouch nolouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nolouch nolouch merged commit 59590ee into tikv:master Aug 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants