pdctl: add operator subcommand tests for pd-ctl #1381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rleungx
changed the title
14 tasks
disksing
reviewed
Dec 17, 2018
pkg/integration_test/pdctl_test.go
Outdated
| args = []string{"-u", pdAddr, "operator", "show"} | ||
| _, output, err = executeCommandC(cmd, args...) | ||
| c.Assert(err, IsNil) | ||
| c.Assert(strings.Contains(string(output), "split region with policy APPROXIMATE"), IsTrue) |
There was a problem hiding this comment.
The test processes are all the same. I think you can make it table-driven:
cmds := []struct{args []string, outputPattern string} {...}
rleungx
force-pushed
the
operator-test
branch
from
012872b
to
706b71a
Compare
disksing
approved these changes
Dec 18, 2018
nolouch
approved these changes
Dec 19, 2018
Signed-off-by: rleungx <rleungx@gmail.com>
rleungx
force-pushed
the
operator-test
branch
from
5e88fa4
to
587a222
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Part of #1328.
What is changed and how it works?
This PR adds some tests for
operatorsubcommand inpd-ctl.Check List
Tests