test: split integration tests into different packages #1391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rleungx
added
component/testing
Signed-off-by: rleungx <rleungx@gmail.com>
rleungx
removed
the
do-not-merge/work-in-progress
disksing
reviewed
Dec 21, 2018
There was a problem hiding this comment.
Reviewed 14 of 14 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @rleungx and @nolouch)
a discussion (no related file):
No Makefile update?
Signed-off-by: rleungx <rleungx@gmail.com>
disksing
approved these changes
Dec 24, 2018
|
/run-unit-test |
2 similar comments
|
/run-unit-test |
|
/run-unit-test |
|
/rebuild |
nolouch
approved these changes
Dec 27, 2018
nolouch
pushed a commit
to nolouch/pd
that referenced
this pull request
Dec 27, 2018
* split integration tests Signed-off-by: rleungx <rleungx@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Currently, the tests in
pkg/integration_testoften fail since the port has been used. The more test cases we have, the easier the test is to fail.What is changed and how it works?
This PR divides these tests into different packages in order to utilize our
jenkinsCI to speed up the tests and avoid port conflicts.Check List
Tests
This change is