New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: move region_statistics into statistics package #1573
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Signed-off-by: Ryan Leung <rleungx@gmail.com>
rleungx
force-pushed
the
split-statistics-2
branch
from
June 17, 2019 03:10
f20e759
to
c54461e
Compare
nolouch
approved these changes
Jun 17, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
disksing
approved these changes
Jun 17, 2019
nolouch
pushed a commit
to nolouch/pd
that referenced
this pull request
Jun 24, 2019
* split statistics from core package Signed-off-by: Ryan Leung <rleungx@gmail.com> * address comments Signed-off-by: Ryan Leung <rleungx@gmail.com> * move store_statistics into statistics package Signed-off-by: Ryan Leung <rleungx@gmail.com> * move region_statistics into statistics package Signed-off-by: Ryan Leung <rleungx@gmail.com> * fix the conflicts Signed-off-by: Ryan Leung <rleungx@gmail.com>
nolouch
added a commit
that referenced
this pull request
Jun 24, 2019
* schedule: move all NewOperator into operator (#1549) * move all NewOperator into operator.go Signed-off-by: Ryan Leung <rleungx@gmail.com> * separate hot cache from basic cluster (#1557) Signed-off-by: Ryan Leung <rleungx@gmail.com> * move mock functions into a separate package (#1562) Signed-off-by: Ryan Leung <rleungx@gmail.com> * *: split statistics from core package (#1565) * split statistics from core package Signed-off-by: Ryan Leung <rleungx@gmail.com> * split tests into different packages (#1550) Signed-off-by: Ryan Leung <rleungx@gmail.com> * schedule: adjust store balance rate meaning (#1589) Signed-off-by: Ryan Leung <rleungx@gmail.com> * schedule: introduce the waiting operators (#1494) * introduce the waiting operators * add random buckets for waiting operators Signed-off-by: Ryan Leung <rleungx@gmail.com> * pdctl: config show command add replication config (#1587) * pd-ctl config show add replication config Signed-off-by: nolouch <nolouch@gmail.com> * server: use a different timeout for http clients (#1574) * use a different timeout for http clients * *: move store_statistics into statistics package (#1572) * split statistics from core package Signed-off-by: Ryan Leung <rleungx@gmail.com> * *: move region_statistics into statistics package (#1573) * split statistics from core package Signed-off-by: Ryan Leung <rleungx@gmail.com> * address comments Signed-off-by: Ryan Leung <rleungx@gmail.com> * move store_statistics into statistics package Signed-off-by: Ryan Leung <rleungx@gmail.com> * move region_statistics into statistics package Signed-off-by: Ryan Leung <rleungx@gmail.com> * fix the conflicts Signed-off-by: Ryan Leung <rleungx@gmail.com> * set detached as default mode for pd-ctl (#1567) * set detached as default mode for pd-ctl * pdctl: fix subcommand option (#1582) * fix subcommand option Signed-off-by: Ryan Leung <rleungx@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Part of modularizing PD.
What is changed and how it works?
This PR moves
region_statistics
into thestatistics
package.Check List
Tests