Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: move region_statistics into statistics package #1573

Merged
merged 5 commits into from Jun 17, 2019

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Jun 11, 2019

What problem does this PR solve?

Part of modularizing PD.

What is changed and how it works?

This PR moves region_statistics into the statistics package.

Check List

Tests

  • Unit test

Signed-off-by: Ryan Leung <rleungx@gmail.com>
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Copy link
Contributor

@nolouch nolouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@disksing disksing merged commit b2cf25d into tikv:master Jun 17, 2019
nolouch pushed a commit to nolouch/pd that referenced this pull request Jun 24, 2019
* split statistics from core package

Signed-off-by: Ryan Leung <rleungx@gmail.com>

* address comments

Signed-off-by: Ryan Leung <rleungx@gmail.com>

* move store_statistics into statistics package

Signed-off-by: Ryan Leung <rleungx@gmail.com>

* move region_statistics into statistics package

Signed-off-by: Ryan Leung <rleungx@gmail.com>

* fix the conflicts

Signed-off-by: Ryan Leung <rleungx@gmail.com>
nolouch added a commit that referenced this pull request Jun 24, 2019
* schedule: move all NewOperator into operator (#1549)

* move all NewOperator into operator.go

Signed-off-by: Ryan Leung <rleungx@gmail.com>

* separate hot cache from basic cluster (#1557)

Signed-off-by: Ryan Leung <rleungx@gmail.com>

* move mock functions into a separate package (#1562)

Signed-off-by: Ryan Leung <rleungx@gmail.com>

* *: split statistics from core package (#1565)

* split statistics from core package

Signed-off-by: Ryan Leung <rleungx@gmail.com>

* split tests into different packages (#1550)

Signed-off-by: Ryan Leung <rleungx@gmail.com>

* schedule: adjust store balance rate meaning (#1589)

Signed-off-by: Ryan Leung <rleungx@gmail.com>

* schedule: introduce the waiting operators (#1494)

* introduce the waiting operators
* add random buckets for waiting operators
Signed-off-by: Ryan Leung <rleungx@gmail.com>

* pdctl: config show command add replication config (#1587)

* pd-ctl config show add replication config
Signed-off-by: nolouch <nolouch@gmail.com>

* server: use a different timeout for http clients (#1574)

* use a different timeout for http clients

* *: move store_statistics into statistics package (#1572)

* split statistics from core package

Signed-off-by: Ryan Leung <rleungx@gmail.com>

* *: move region_statistics into statistics package (#1573)

* split statistics from core package

Signed-off-by: Ryan Leung <rleungx@gmail.com>

* address comments

Signed-off-by: Ryan Leung <rleungx@gmail.com>

* move store_statistics into statistics package

Signed-off-by: Ryan Leung <rleungx@gmail.com>

* move region_statistics into statistics package

Signed-off-by: Ryan Leung <rleungx@gmail.com>

* fix the conflicts

Signed-off-by: Ryan Leung <rleungx@gmail.com>

* set detached as default mode for pd-ctl (#1567)

* set detached as default mode for pd-ctl

* pdctl: fix subcommand option (#1582)

* fix subcommand option

Signed-off-by: Ryan Leung <rleungx@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants