Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schedule: fix store maybe always overloaded (#1586) #1590

Merged
merged 1 commit into from Jun 20, 2019

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Jun 20, 2019

What problem does this PR solve?

cherry-pick #1586.

Check List

Tests

  • Unit test

* fix store maybe always overloaded

Signed-off-by: Ryan Leung <rleungx@gmail.com>
@codecov-io
Copy link

Codecov Report

Merging #1590 into release-3.0 will increase coverage by 0.11%.
The diff coverage is 100%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-3.0    #1590      +/-   ##
===============================================
+ Coverage        67.61%   67.73%   +0.11%     
===============================================
  Files              159      159              
  Lines            16275    16258      -17     
===============================================
+ Hits             11004    11012       +8     
+ Misses            4305     4281      -24     
+ Partials           966      965       -1
Impacted Files Coverage Δ
server/schedule/scheduler.go 66.66% <ø> (ø) ⬆️
server/core/store.go 80.75% <100%> (+2.18%) ⬆️
server/cluster_info.go 86.73% <100%> (+1.51%) ⬆️
server/schedule/operator_controller.go 86.38% <100%> (+1%) ⬆️
server/core/store_option.go 100% <100%> (+5.88%) ⬆️
server/schedule/basic_cluster.go 89.09% <100%> (+3.12%) ⬆️
pkg/etcdutil/etcdutil.go 86.04% <0%> (-9.31%) ⬇️
server/etcd_kv.go 65.95% <0%> (-4.26%) ⬇️
server/namespace_cluster.go 81.81% <0%> (-3.9%) ⬇️
server/region_syncer/client.go 79.74% <0%> (-3.8%) ⬇️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ccec24...eedc3cf. Read the comment docs.

@disksing disksing merged commit 57238dd into tikv:release-3.0 Jun 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants