Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: add a option about gRPC gateway #1596

Merged
merged 3 commits into from Jun 26, 2019
Merged

Conversation

nolouch
Copy link
Contributor

@nolouch nolouch commented Jun 24, 2019

Signed-off-by: nolouch nolouch@gmail.com

What problem does this PR solve?

After upgrade the etcd, the gRPC gateway does not enable in default(etcd-io/etcd#10392). Our tidb-ctl use it. Now, add a config to enable it.

What is changed and how it works?

add a configurable item.

Check List

Tests

  • Unit test

Signed-off-by: nolouch <nolouch@gmail.com>
@disksing
Copy link
Contributor

BTW, switch -> option?

@nolouch nolouch changed the title config: add a switch about gRPC gateway config: add a option about gRPC gateway Jun 24, 2019
@nolouch nolouch merged commit ab9b702 into tikv:master Jun 26, 2019
@nolouch nolouch added the needs-cherry-pick-release-3.0 The PR needs to cherry pick to release-3.0 branch. label Jun 26, 2019
@nolouch nolouch deleted the add-grpc-gateway branch June 26, 2019 03:35
nolouch added a commit to nolouch/pd that referenced this pull request Jul 3, 2019
Signed-off-by: nolouch <nolouch@gmail.com>
disksing pushed a commit that referenced this pull request Jul 3, 2019
* schedulers: fix the issue about the limit of the hot region (#1552)

Signed-off-by: nolouch <nolouch@gmail.com>

* config: add a switch about grpc gateway (#1596)

Signed-off-by: nolouch <nolouch@gmail.com>

* statistics: add the missing schedule config items (#1601)

Signed-off-by: nolouch <nolouch@gmail.com>

* update changelog

Signed-off-by: nolouch <nolouch@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-3.0 The PR needs to cherry pick to release-3.0 branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants