schedule: fix merge related operators in waiting operators #1633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Leung <rleungx@gmail.com>
rleungx
changed the title
Signed-off-by: Ryan Leung <rleungx@gmail.com>
nolouch
approved these changes
Jul 11, 2019
rleungx
added
the
needs-cherry-pick-release-3.0
rleungx
added a commit
to rleungx/pd
that referenced
this pull request
Jul 12, 2019
* fix random merge in waiting operators Signed-off-by: Ryan Leung <rleungx@gmail.com>
rleungx
added a commit
that referenced
this pull request
Jul 15, 2019
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Currently, we only take
merge-regioninto consideration. Butrandom-mergeandadmin-merge-regionalso need to be considered.What is changed and how it works?
This PR uses
Kind()instead ofDesc()to decide if we need to get another operator.Check List
Tests