Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: add a API to clear tombstone store (#1472) #1705

Merged
merged 4 commits into from
Aug 29, 2019
Merged

*: add a API to clear tombstone store (#1472) #1705

merged 4 commits into from
Aug 29, 2019

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Aug 26, 2019

What problem does this PR solve?

cherry-pick #1472.

Check List

Tests

  • Unit test

Code changes

  • Has HTTP API interfaces change

Related changes

  • Need to be included in the release notes

@rleungx
fix the escape problem
d33c1eb 
Signed-off-by: Ryan Leung <rleungx@gmail.com>
@rleungx rleungx requested review from disksing, nolouch and Luffbee and removed request for disksing August 26, 2019 11:43
@rleungx
fix the conflicts
a133bb0 
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Luffbee
Luffbee reviewed Aug 26, 2019
View reviewed changes
Copy link
Contributor

@Luffbee Luffbee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

api.raml also need update.

@rleungx
update api.raml
46bf532 
Signed-off-by: Ryan Leung <rleungx@gmail.com>
@rleungx
Copy link
Member Author

rleungx commented Aug 27, 2019

PTAL @Luffbee

@rleungx
Copy link
Member Author

rleungx commented Aug 28, 2019

/run-all-tests tidb=release-2.1 tikv=release-2.1 tidb-test=release-2.1

@rleungx rleungx requested a review from Luffbee August 29, 2019 03:33
shafreeck
shafreeck approved these changes Aug 29, 2019
View reviewed changes
Copy link
Contributor

@shafreeck shafreeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nolouch nolouch added the status/can-merge Indicates a PR has been approved by a committer. label Aug 29, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Aug 29, 2019

/run-all-tests

@sre-bot sre-bot merged commit 539f50e into tikv:release-2.1 Aug 29, 2019
@rleungx rleungx mentioned this pull request Sep 5, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shafreeck shafreeck shafreeck approved these changes

@nolouch nolouch nolouch approved these changes

@disksing disksing Awaiting requested review from disksing

@Luffbee Luffbee Awaiting requested review from Luffbee

Assignees
No one assigned
Labels
status/can-merge Indicates a PR has been approved by a committer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@rleungx @sre-bot @shafreeck @nolouch @Luffbee @bradyjoestar