New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api: support delete store label by setting it to empty #2044
Conversation
Signed-off-by: disksing <i@disksing.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. do we need to add doc to mention it
Good idea. |
Signed-off-by: disksing <i@disksing.com>
Codecov Report
@@ Coverage Diff @@
## master #2044 +/- ##
==========================================
- Coverage 76.97% 76.74% -0.24%
==========================================
Files 185 185
Lines 18829 18835 +6
==========================================
- Hits 14493 14454 -39
- Misses 3236 3272 +36
- Partials 1100 1109 +9
Continue to review full report at Codecov.
|
/merge |
/run-all-tests |
Signed-off-by: disksing i@disksing.com
What problem does this PR solve?
cannot delete store label.
What is changed and how it works?
delete label by setting it to empty.
Check List
Tests
Code changes