Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: support delete store label by setting it to empty #2044

Merged
merged 4 commits into from Dec 25, 2019

Conversation

disksing
Copy link
Contributor

Signed-off-by: disksing i@disksing.com

What problem does this PR solve?

cannot delete store label.

What is changed and how it works?

delete label by setting it to empty.

Check List

Tests

  • Unit test
  • Manual test (add detailed scripts or steps below)

Code changes

  • Has HTTP API interfaces change

Signed-off-by: disksing <i@disksing.com>
@disksing disksing added the component/api HTTP API. label Dec 23, 2019
@disksing disksing added this to the v4.0.0-beta milestone Dec 23, 2019
Copy link
Contributor

@lhy1024 lhy1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. do we need to add doc to mention it

@disksing
Copy link
Contributor Author

LGTM. do we need to add doc to mention it

Good idea.

Signed-off-by: disksing <i@disksing.com>
@codecov-io
Copy link

Codecov Report

Merging #2044 into master will decrease coverage by 0.23%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2044      +/-   ##
==========================================
- Coverage   76.97%   76.74%   -0.24%     
==========================================
  Files         185      185              
  Lines       18829    18835       +6     
==========================================
- Hits        14493    14454      -39     
- Misses       3236     3272      +36     
- Partials     1100     1109       +9
Impacted Files Coverage Δ
server/core/store.go 78.62% <100%> (+0.29%) ⬆️
server/config/util.go 75% <100%> (+3.57%) ⬆️
server/member/leader.go 73.97% <0%> (-7.15%) ⬇️
server/region_syncer/client.go 77.1% <0%> (-4.82%) ⬇️
server/schedulers/random_merge.go 60.71% <0%> (-3.58%) ⬇️
server/schedule/region_scatterer.go 77.65% <0%> (-3.2%) ⬇️
client/client.go 72.23% <0%> (-1.82%) ⬇️
server/grpc_service.go 57.23% <0%> (-1.73%) ⬇️
pkg/btree/btree.go 86.84% <0%> (-0.81%) ⬇️
server/handler.go 48.91% <0%> (-0.44%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4336d59...2bedbf9. Read the comment docs.

@disksing
Copy link
Contributor Author

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 25, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Dec 25, 2019

/run-all-tests

@sre-bot sre-bot merged commit b93c794 into tikv:master Dec 25, 2019
@disksing disksing deleted the del-label branch March 19, 2020 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/api HTTP API. status/can-merge Indicates a PR has been approved by a committer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants