config: fix config parsing. #225
Merged
+12
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
| @@ -145,22 +145,21 @@ func adjustInt64(v *int64, defValue int64) { | |||
|
|
|||
| // Parse parses flag definitions from the argument list. | |||
| func (c *Config) Parse(arguments []string) error { | |||
| flagArgs := make(map[string]*flag.Flag) | |||
| flag.Visit(func(flag *flag.Flag) { | |||
There was a problem hiding this comment.
This Visit() function visits only those flags that have been set.
Before we Parse(), all flags are unset, so we always get an empty flagArgs.
|
LGTM |
| if err != nil { | ||
| return errors.Trace(err) | ||
| } | ||
|
|
There was a problem hiding this comment.
How about moving line 168 check here?
There was a problem hiding this comment.
I think we only do a trick to get the config file here, we should leave the check at the end.
I don't think we should care performance here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix some bugs here.
PTAL @qiuyesuifeng @siddontang @shenli