add admin operators. #308
Merged
add admin operators. #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if err != nil { | ||
| return errors.Trace(err) | ||
| } | ||
| defer r.Body.Close() |
There was a problem hiding this comment.
seem that you can still use r.Body.Close here directly.
There was a problem hiding this comment.
I can't, io.Reader has no Close method.
There was a problem hiding this comment.
You can use io.ReadCloser instead
huachaohuang
force-pushed
the
huachaohuang/admin-operators
branch
from
cf9defd
to
e9f16fa
Compare
huachaohuang
force-pushed
the
huachaohuang/admin-operators
branch
from
e9f16fa
to
cef6214
Compare
|
LGTM |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.