Makefile, travis: miscellaneous fix #349
Conversation
* ignore pd-server in tests and coveralls * ignore a generated go-bindata file in coveralls * prevent stall jobs in travis tests by extending testing time
|
PTAL @siddontang @huachaohuang |
| @@ -16,4 +16,4 @@ matrix: | |||
| script: | |||
| - make dev | |||
| after_success: | |||
| - make travis_coverage | |||
| - travis_wait make travis_coverage | |||
There was a problem hiding this comment.
A magic function that automatically doubles testing timeout. Now the extended timeout is 20 minutes.
There was a problem hiding this comment.
There was a problem hiding this comment.
em, does PD can run 20m+ in travis? If yes, it is too long, we must speed up the test.
There was a problem hiding this comment.
No, PD won't run 20m+.
Sometimes make travis_coverage may run more than 10 minutes and outputs nothing, that may cause travis build error, because travis thinks it is a stall job.
Here travis_wait extends timeout, so that we prevent stall jobs.
There was a problem hiding this comment.
If make travis_coverage runs over 20m, is it still a stall job?
There was a problem hiding this comment.
Yes, though highly unlikely. There must be something wrong in our tests, if it happened.
There was a problem hiding this comment.
So I think we don't need this, if > 10m, it is our bug and we must fix it.
There was a problem hiding this comment.
I think we should keep it, I received a build error email yesterday because of no outputs within 10 minutes, and I am pretty sure it is not caused by bugs, sometimes travis machines become slow make travis_coverage may run more than 10 mintues.
BTW, make travis_coverage casts 15min+ in my machine.
|
LGTM |
1 similar comment
|
LGTM |
close #347