Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server/store: embed metapb.Store into storeInfo #352

Merged
merged 1 commit into from
Oct 22, 2016
Merged

server/store: embed metapb.Store into storeInfo #352

merged 1 commit into from
Oct 22, 2016

Conversation

huachaohuang
Copy link
Contributor

@huachaohuang huachaohuang commented Oct 20, 2016 •
edited
Loading

Embed metapb.Store into storeInfo to make the code more clean.

@siddontang
Copy link
Contributor

Please add description for your PR

overvenus
overvenus approved these changes Oct 21, 2016
View reviewed changes
Copy link
Member

@overvenus overvenus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@huachaohuang
Copy link
Contributor Author

@siddontang PTAL

@siddontang
Copy link
Contributor

LGTM

@huachaohuang huachaohuang merged commit 54c0f7b into master Oct 22, 2016
@huachaohuang huachaohuang deleted the huachaohuang/embed-store branch October 22, 2016 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@overvenus overvenus overvenus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@huachaohuang @siddontang @overvenus