Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pd-client: add request duration metric #354

Merged
merged 1 commit into from
Oct 22, 2016
Merged

pd-client: add request duration metric #354

merged 1 commit into from
Oct 22, 2016
+24 −0

Conversation

huachaohuang
Copy link
Contributor

No description provided.

@siddontang
Copy link
Contributor

What's the different with CmdDuration metric?

@huachaohuang
Copy link
Contributor Author

huachaohuang commented Oct 22, 2016 •
edited
Loading

cmdDuration measures only the RPC duration, but we encounter a problem when the cmdDuration seems fine but GetTS() takes very loog.
requestDuration measures the whole cost of the request.

@siddontang
Copy link
Contributor

LGTM

@siddontang
Copy link
Contributor

PTAL @overvenus

overvenus
overvenus approved these changes Oct 22, 2016
View reviewed changes
Copy link
Member

@overvenus overvenus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@huachaohuang huachaohuang merged commit c0af22f into master Oct 22, 2016
@huachaohuang huachaohuang deleted the huachaohuang/add-some-metrics branch October 22, 2016 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@overvenus overvenus overvenus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@huachaohuang @siddontang @overvenus