server/balancer: add scheduler and simplify schedule configs #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huachaohuang
changed the title
ngaut
changed the title
huachaohuang
force-pushed
the
huachao/cleanup-metrics
branch
from
e3328b6
to
8a7be0b
Compare
huachaohuang
force-pushed
the
huachao/scheduler
branch
from
13e4aa7
to
6ceda7f
Compare
huachaohuang
changed the base branch from
huachao/cleanup-metrics
to
develop
huachaohuang
changed the title
siddontang
reviewed
Nov 28, 2016
| return 0, nil, nil | ||
| } | ||
| func (l *leaderBalancer) GetResourceKind() ResourceKind { | ||
| return l.kind |
There was a problem hiding this comment.
seem that the kind is fixed for leader and storage balancer, why not returning the const var directly?
huachaohuang
force-pushed
the
develop
branch
from
d0882e1
to
3ec79d2
Compare
I think the score things are too complicated, we can calculate the scores more easily.
The original balance configs are complicated and some of them are very confusing, now we simplify them to make it more easy to understand. We replace the concept of "balance" with "schedule". Balance means to keep the resource balance, but we will introduce different kinds of strategies in the future which may not balance, and balance is just one kind of strategies to schedule resources between stores.
huachaohuang
force-pushed
the
huachao/scheduler
branch
from
355ae95
to
2ff737d
Compare
|
Cool, LGTM |
|
PTAL @overvenus |
overvenus
approved these changes
Nov 29, 2016
| func (cf *capacityFilter) FilterSource(store *storeInfo) bool { | ||
| return store.storageRatio() <= cf.cfg.MinCapacityUsedRatio | ||
| func (f *regionCountFilter) FilterTarget(store *storeInfo) bool { | ||
| return false |
There was a problem hiding this comment.
This filter is used to filter source stores with regions fewer than MinRegionCount, it doesn't filter target stores, so it just returns false.
huachaohuang
added a commit
that referenced
this pull request
Nov 29, 2016
The original balance configs are complicated and some of them are very confusing, now we simplify them to make it more easy to understand. We replace the concept of "balance" with "schedule". Balance means to keep the resource balance, but we will introduce different kinds of strategies in the future which may not balance, and balance is just one kind of strategies to schedule resources between stores.
huachaohuang
added a commit
that referenced
this pull request
Dec 1, 2016
The original balance configs are complicated and some of them are very confusing, now we simplify them to make it more easy to understand. We replace the concept of "balance" with "schedule". Balance means to keep the resource balance, but we will introduce different kinds of strategies in the future which may not balance, and balance is just one kind of strategies to schedule resources between stores.
huachaohuang
added a commit
that referenced
this pull request
Dec 7, 2016
The original balance configs are complicated and some of them are very confusing, now we simplify them to make it more easy to understand. We replace the concept of "balance" with "schedule". Balance means to keep the resource balance, but we will introduce different kinds of strategies in the future which may not balance, and balance is just one kind of strategies to schedule resources between stores.
huachaohuang
added a commit
that referenced
this pull request
Dec 8, 2016
The original balance configs are complicated and some of them are very confusing, now we simplify them to make it more easy to understand. We replace the concept of "balance" with "schedule". Balance means to keep the resource balance, but we will introduce different kinds of strategies in the future which may not balance, and balance is just one kind of strategies to schedule resources between stores.
huachaohuang
added a commit
that referenced
this pull request
Dec 8, 2016
* server/selector: add selector interface and balance selector (#388) We can use selector to abstract different strategies to select the source and target stores. * server: use selector to schedule region peer (#389) * server/resource: replace score type with resource kind (#393) I think the score things are too complicated, we can calculate the scores more easily. * server/metrics: remove redundant metrics (#395) * server/balancer: add scheduler and simplify schedule configs (#396) The original balance configs are complicated and some of them are very confusing, now we simplify them to make it more easy to understand. We replace the concept of "balance" with "schedule". Balance means to keep the resource balance, but we will introduce different kinds of strategies in the future which may not balance, and balance is just one kind of strategies to schedule resources between stores. * server/coordinator: replace balancer worker with coordinator (#398) Coordinator can control the speed of different schedulers. Every scheduler has a unique name, we can add API to run or stop any schedulers dynamically, and different schedulers can run concurrently. * server/constraints: add replication constraints (#402) * server/scheduler: add grant-leader-scheduler (#406) * server/coordinator: combine scheduler and controller * server/api: add scheduler api (#407) We can now use API to list all schedulers, add or remove a scheduler. * Add shuffle-leader-scheduler (#409) * server/scheduler: add shuffle-leader-scheduler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original balance configs are complicated and some of them are very
confusing, now we simplify them to make it more easy to understand.
We replace the concept of "balance" with "schedule". Balance means to
keep the resource balance, but we will introduce different kinds of
strategies in the future which may not balance, and balance is just one
kind of strategies to schedule resources between stores