httpapi: support /status to show PD version #664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Please sign the CLA @choleraehyq . |
disksing
reviewed
Jun 29, 2017
| @@ -0,0 +1,34 @@ | |||
| package api | |||
There was a problem hiding this comment.
Add license header at the top of the file.
siddontang
reviewed
Jun 29, 2017
server/api/status.go
Outdated
| } | ||
|
|
||
| func (h *statusHandler) ServeHTTP(w http.ResponseWriter, r *http.Request) { | ||
| w.Header().Set("Content-Type", "application/json") |
There was a problem hiding this comment.
seem the default type is json, no need to set this, please ensure it.
There was a problem hiding this comment.
Yes. I removed it.
|
LGTM |
|
Please add test |
Signed-off-by: Cholerae Hu <choleraehyq@gmail.com>
Signed-off-by: Cholerae Hu <choleraehyq@gmail.com>
Signed-off-by: Cholerae Hu <choleraehyq@gmail.com>
|
@siddontang Test added. |
siddontang
reviewed
Jun 30, 2017
server/api/status_test.go
Outdated
| resp, err := s.hc.Get(addr) | ||
| c.Assert(err, IsNil) | ||
| buf, err := ioutil.ReadAll(resp.Body) | ||
| c.Assert(err, IsNil) |
siddontang
reviewed
Jun 30, 2017
server/api/status_test.go
Outdated
|
|
||
| for _, num := range numbers { | ||
| cfgs, _, clean := mustNewCluster(c, num) | ||
| defer clean() |
There was a problem hiding this comment.
don't call defer in for loop.
Signed-off-by: Cholerae Hu <choleraehyq@gmail.com>
|
PTAL @disksing |
|
@disksing Can this be merged? |
sre-bot
added
the
contribution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #551
PTAL @siddontang @nolouch
Signed-off-by: Cholerae Hu choleraehyq@gmail.com