Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pd-recover parameter error message is incorrect #668

Merged
merged 2 commits into from
Jul 6, 2017
Merged

pd-recover parameter error message is incorrect #668

merged 2 commits into from
Jul 6, 2017

Conversation

aliyx
Copy link
Contributor

@aliyx aliyx commented Jun 30, 2017

No description provided.

@CLAassistant
Copy link

CLAassistant commented Jun 30, 2017 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@siddontang
Copy link
Contributor

LGTM @aliyx

Please sign the CLA.

@siddontang
Copy link
Contributor

PTAL @disksing

nolouch
nolouch approved these changes Jul 3, 2017
View reviewed changes
Copy link
Contributor

@nolouch nolouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@disksing
Copy link
Contributor

disksing commented Jul 3, 2017

LGTM.
Thanks for your PR @aliyx . Before merge, we need you to sign our CLA by clicking the 'CLA: not signed yet' button above.

@siddontang
Copy link
Contributor

Any update @aliyx

@aliyx
Copy link
Contributor Author

aliyx commented Jul 6, 2017

@disksing i had sign CLA.

@disksing
Copy link
Contributor

disksing commented Jul 6, 2017

Cheers. Thanks for your contribution. @aliyx

@disksing disksing merged commit e74a99e into tikv:master Jul 6, 2017
@sre-bot sre-bot added the contribution Indicates that the PR was contributed by an external member. label Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nolouch nolouch nolouch approved these changes

Assignees
No one assigned
Labels
contribution Indicates that the PR was contributed by an external member.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@aliyx @CLAassistant @siddontang @disksing @nolouch @sre-bot