server: reduce lock scope for region heartbeat. #677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM PTAL @huachaohuang |
| origin := c.regions.getRegion(region.GetId()) | ||
| c.RUnlock() |
There was a problem hiding this comment.
The cache and kv may not be consistent, for example, if a region's leader sends a heartbeat and then elects another leader and sends another heartbeat with a new version. But it seems not a problem, because they will be consistent finally?
There was a problem hiding this comment.
yes, we will guarantee eventual consistency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main purpose is to avoid holding mutex to write kv.