fix score when region size is zero #899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nolouch
reviewed
Jan 4, 2018
| // Region1: L F F F | ||
| s.tc.updateLeaderCount(1, 10) | ||
| s.tc.updateLeaderCount(1, 16) |
There was a problem hiding this comment.
note that: shouldBalance() uses math.Min(sourceSizeDiff, targetSizeDiff) >= float64(region.ApproximateSize)*tolerantRatio to decide whether to balance.
Before when size is zero, score is zero. for this case,
// Stores: 1 2 3 4
// Score: 100 0 0 0
avgScore is 25, and sizediff satisfy the formula above just enough
After when size is zero, score is 1, so for this case
// Stores: 1 2 3 4
// Score: 100 1 1 1
avgScore is 25.75, and sizediff doesn't satisfy the formula above
so enlarge the leader count
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when region size is zero, the score will be zero accordingly. When scheduler move this kind of regions, the score of store isn't affected, leading to maldistribution of region count for stores.