Change return type of Raft::new() to Result #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Hoverbear @BusyJay PTAL |
Hoverbear
added
Enhancement
|
Hi @kleimkuhler, thanks for this! I'm scheduling this for 0.5.0 so it's got a DNM for the moment. |
Hoverbear
reviewed
Sep 12, 2018
|
@Hoverbear Added the additional Seems this is gaining some additional "Merge branch ..." commits. I can squash everything down if you'd like; I'm not sure how clean your team likes to keep the git history! |
Hoverbear
previously approved these changes
Sep 17, 2018
|
@kleimkuhler Whoops! We both forgot the benchmarks! Could you please bump those too? |
|
@Hoverbear Totally missed the benchmarking; sorry about that! Everything should be good to go now. |
This allows a ConfigInvalid error to propogate up and let user handle it.
|
LGTM. |
hicqu
approved these changes
Sep 29, 2018
Hoverbear
approved these changes
Oct 2, 2018
|
Thanks a lot for your work on this @kleimkuhler ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows a
ConfigInvaliderror to propogate up and let user handle it.Fixes #94