Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix leader's progress state to Replicate (#143) #146

Merged
merged 1 commit into from
Nov 30, 2018
Merged

Fix leader's progress state to Replicate (#143) #146

merged 1 commit into from
Nov 30, 2018

Conversation

Xavier1994
Copy link
Contributor

related to #143

fix leader's progress state to replicate

Hoverbear
Hoverbear approved these changes Nov 29, 2018
View reviewed changes
Copy link
Contributor

@Hoverbear Hoverbear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi!

Thanks for this contribution! It looks good to me. :)

@Hoverbear
Copy link
Contributor

@Connor1996 Can you PTAL?

@Hoverbear Hoverbear added this to the 0.5.0 milestone Nov 29, 2018
@Hoverbear Hoverbear added the Bug Recognized misbehavior. label Nov 29, 2018
nolouch
nolouch approved these changes Nov 30, 2018
View reviewed changes
Copy link
Contributor

@nolouch nolouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nolouch nolouch merged commit 6f6afc5 into tikv:master Nov 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hoverbear Hoverbear Hoverbear approved these changes

@nolouch nolouch nolouch approved these changes

@Connor1996 Connor1996 Awaiting requested review from Connor1996

Assignees
No one assigned
Labels
Bug Recognized misbehavior.
Projects
None yet
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Xavier1994 @Hoverbear @nolouch