Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix feature so it functions on stable #180

Merged
merged 1 commit into from
Feb 11, 2019
Merged

Fix feature so it functions on stable #180

merged 1 commit into from
Feb 11, 2019

Conversation

Hoverbear
Copy link
Contributor

As seen in this tikv/client-rust#22 build https://travis-ci.org/tikv/client-rust/jobs/486189743.

Once merged we should probably tag a patch version and release it, since this could be affecting other downstreams.

@Hoverbear Hoverbear added Bug Recognized misbehavior. Tooling/Testing CI, benchmarking, and testing infrastucture. labels Feb 7, 2019
@Hoverbear Hoverbear self-assigned this Feb 7, 2019
@Hoverbear Hoverbear requested a review from brson February 7, 2019 18:20
brson
brson approved these changes Feb 8, 2019
View reviewed changes
Copy link

@brson brson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Note though that I don't know how recent this "::" attribute syntax is, so this patch itself could possibly break backwards compatibility with older stable toolchains. Whether that matters is up to you.

siddontang
siddontang approved these changes Feb 8, 2019
View reviewed changes
Copy link
Contributor

@siddontang siddontang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hoverbear Hoverbear merged commit 311b3b5 into master Feb 11, 2019
@Hoverbear Hoverbear deleted the clippy-feature branch February 11, 2019 18:05
@Hoverbear Hoverbear added this to the 0.5.0 milestone Feb 11, 2019
@Hoverbear Hoverbear mentioned this pull request Feb 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brson brson brson approved these changes

@siddontang siddontang siddontang approved these changes

Assignees

@Hoverbear Hoverbear

Labels
Bug Recognized misbehavior. Tooling/Testing CI, benchmarking, and testing infrastucture.
Projects
None yet
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Hoverbear @brson @siddontang