Learner needs to respond vote requests. #58
Conversation
|
@BusyJay @Hoverbear @overvenus PTAL thanks. |
hicqu
force-pushed
the
learner-vote-response
branch
from
4dd5c84
to
d2c8ff5
Compare
src/raft.rs
Outdated
| at term {}", | ||
| self.tag, | ||
| if self.is_learner { "learner" } else { "voter" }, |
tests/cases/test_raft.rs
Outdated
| nw.peers.get_mut(&3).unwrap().tick(); | ||
| } | ||
|
|
||
| // MsgRequeestVote should only come from 1. |
There was a problem hiding this comment.
Too many es in MsgRequeestVote
|
@hicqu I see that in #57 (comment) a candidate check was written about. In this PR I don't see an added candidate check. Was this already implemented, or found to be unnecessary? |
|
@Hoverbear I omitted the check, because voters only send |
|
ping @BusyJay @overvenus . |
tests/cases/test_raft.rs
Outdated
| }; | ||
|
|
||
| let mut network = Network::new(vec![Some(n1), None, Some(n3)]); | ||
| network.isolate(2); |
There was a problem hiding this comment.
None means it won't respond to requests already.
There was a problem hiding this comment.
After I remove this, store 1 will be elected as leader.
tests/cases/test_raft.rs
Outdated
| let do_campaign = |nw: &mut Network| { | ||
| for _ in 0..timeout << 1 { | ||
| nw.peers.get_mut(&1).unwrap().tick(); | ||
| nw.peers.get_mut(&3).unwrap().tick(); |
There was a problem hiding this comment.
What's the point of ticking node 3?
There was a problem hiding this comment.
To show all Vote messages come from store 1 even if 3 will also step(MsgHup).
There was a problem hiding this comment.
I don't get it. Where are all those messages showed? How does it help with the test case?
tests/cases/test_raft.rs
Outdated
| } | ||
|
|
||
| // MsgRequestVote should only come from 1. | ||
| let msgs = read_messages(nw.peers.get_mut(&1).unwrap()); |
There was a problem hiding this comment.
Why not send a MsgHup to node 1 directly?
tests/cases/test_raft.rs
Outdated
| do_campaign(&mut network); | ||
| assert_eq!(network.peers[&1].state, StateRole::Candidate); | ||
|
|
||
| match network.peers.get_mut(&1) { |
hicqu
force-pushed
the
learner-vote-response
branch
from
2bdf8d9
to
faa583c
Compare
|
LGTM |
So that if some voters fail, rest voters and learners can still form a quorum. Fix #57 .