Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rearrange benches #175

Merged
merged 3 commits into from May 24, 2018
Merged

Rearrange benches #175

merged 3 commits into from May 24, 2018

Conversation

overvenus
Copy link
Member

This rearranges benches, also fixes a warning:

warning: An explicit [[bench]] section is specified in Cargo.toml which currently
disables Cargo from automatically inferring other benchmark targets.

@overvenus overvenus requested review from breezewish and siddontang and removed request for breezewish May 22, 2018 14:23
@breezewish
Copy link
Member

LGTM

siddontang
siddontang approved these changes May 24, 2018
View reviewed changes
Copy link
Contributor

@siddontang siddontang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@overvenus overvenus merged commit b36e119 into tikv:master May 24, 2018
@overvenus overvenus deleted the benches branch May 24, 2018 13:19
azdlowry pushed a commit to azdlowry/rust-prometheus that referenced this pull request Sep 10, 2018
@overvenus @azdlowry
Rearrange benches (tikv#175)
2af43b0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siddontang siddontang siddontang approved these changes

@breezewish breezewish breezewish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@overvenus @breezewish @siddontang