Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: test prewrite and commit out of order before initialized (#1319) #1333

Merged
merged 1 commit into from Jan 23, 2021

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Jan 23, 2021

cherry-pick #1319 to release-4.0
You can switch your code base to this Pull Request by using git-extras:

# In ticdc repo:
git pr https://github.com/pingcap/ticdc/pull/1333

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/ticdc.git pr/1333:release-4.0-30fbd24492d9

What problem does this PR solve?

Improve unit test of kv client, part of #1292

What is changed and how it works?

  • Test kv client can handle out of order prewrite and commit before initialized properly
  • Test txn heartbeat event, which is a prewrite without value
  • Test rollback event

Check List

Tests

  • Unit test
  • Integration test

Release note

  • No release note

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot added status/ptal Could you please take a look? component/test Unit tests and integration tests component. type/4.0-cherry-pick labels Jan 23, 2021
@ti-srebot ti-srebot added this to the v4.0.10 milestone Jan 23, 2021
@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 23, 2021
@codecov-io
Copy link

Codecov Report

Merging #1333 (6e4b2e4) into release-4.0 (f28608b) will increase coverage by 0.1071%.
The diff coverage is n/a.

@@                 Coverage Diff                 @@
##           release-4.0      #1333        +/-   ##
===================================================
+ Coverage      46.9692%   47.0763%   +0.1071%     
===================================================
  Files              130        130                
  Lines            13066      13066                
===================================================
+ Hits              6137       6151        +14     
+ Misses            6264       6249        -15     
- Partials           665        666         +1     

@amyangfei
Copy link
Contributor

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 23, 2021
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot merged commit c94082c into pingcap:release-4.0 Jan 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/test Unit tests and integration tests component. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/ptal Could you please take a look?
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants