kv-client: fix stream is not recycled when meeting recv error #1336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amyangfei
added
type/bugfix
|
/run-all-tests |
amyangfei
force-pushed
the
kv-client-ut-stream-recv-failure
branch
from
8e8ed1b
to
571855e
Compare
|
/run-all-tests |
|
/run-all-tests |
amyangfei
added
status/ptal
23 tasks
zier-one
approved these changes
Jan 27, 2021
|
/run-all-tests |
|
/run-integration-tests |
|
/run-all-tests |
|
PTAL @liuzix |
|
LGTM |
ti-srebot
approved these changes
Jan 28, 2021
|
/merge |
ti-srebot
added
the
status/can-merge
|
Your auto merge job has been accepted, waiting for:
|
|
/run-all-tests |
|
@amyangfei merge failed. |
|
/run-all-tests |
|
/run-kafka-tests |
|
/merge |
|
Your auto merge job has been accepted, waiting for:
|
|
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## master #1336 +/- ##
================================================
+ Coverage 48.2311% 48.2330% +0.0018%
================================================
Files 130 130
Lines 13201 13215 +14
================================================
+ Hits 6367 6374 +7
- Misses 6161 6165 +4
- Partials 673 676 +3 |
ti-srebot
pushed a commit
to ti-srebot/ticdc
that referenced
this pull request
Jan 28, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-4.0 in PR #1373 |
amyangfei
added
the
priority/p0
ti-srebot
added a commit
that referenced
this pull request
Jan 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
stream.Recvwith error, but the underlying stream is normal actually (or the next round ofstream.Sendis successfully, then thereceiveFromStreamgoroutine will be never created, and corresponding events will not be consumed by kv client.What is changed and how it works?
receiveFromStreamroutine exits, and remove stream from stream cacheCheck List
Tests
Release note