Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a metric-related bug in etcd/client (#4267) #4284

Merged
merged 7 commits into from
Apr 13, 2022
Merged

Fix a metric-related bug in etcd/client (#4267) #4284

merged 7 commits into from
Apr 13, 2022

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #4267

What problem does this PR solve?

Issue Number: close #4266

What is changed and how it works?

Check List

Side effects

  • None

Related changes

  • None

Release note 

`None`

@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/cherry-pick-not-approved The current cherry-pick pull request has not been approved and cannot be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-5.2 This PR is cherry-picked to release-5.2 from a source PR. labels Jan 12, 2022
@ti-chi-bot ti-chi-bot mentioned this pull request Jan 12, 2022
Merged
@codecov-commenter
Copy link

codecov-commenter commented Jan 17, 2022 •
edited

Codecov Report

❗ No coverage uploaded for pull request base (release-5.2@4d7609c). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             release-5.2      #4284   +/-   ##
================================================
  Coverage               ?   57.4430%           
================================================
  Files                  ?        191           
  Lines                  ?      19273           
  Branches               ?          0           
================================================
  Hits                   ?      11071           
  Misses                 ?       7237           
  Partials               ?        965

@CharlesCheung96
Copy link
Contributor

@nongfushanquan

@CharlesCheung96
Copy link
Contributor

/run-all-tests

@overvenus overvenus added this to the v5.2.4 milestone Jan 17, 2022
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved The current cherry-pick pull request has not been approved and cannot be merged. labels Feb 23, 2022
@CharlesCheung96
Copy link
Contributor

/run-all-tests

@CharlesCheung96
Copy link
Contributor

/run-all-tests

@CharlesCheung96
Copy link
Contributor

/run-kafka-integration-tests
/run-integration-tests

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 25, 2022
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 28, 2022
@CharlesCheung96
Copy link
Contributor

/run-all-tests

@amyangfei
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 121707e

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 13, 2022
@ti-chi-bot ti-chi-bot merged commit d593b56 into pingcap:release-5.2 Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@CharlesCheung96 CharlesCheung96

Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-5.2 This PR is cherry-picked to release-5.2 from a source PR.
Projects
None yet
Milestone
v5.2.4
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ti-chi-bot @codecov-commenter @CharlesCheung96 @amyangfei @overvenus @VelocityLight