-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
schema(cdc): fix DML construct error caused by 'rename tables' DDL (#5068) #5079
schema(cdc): fix DML construct error caused by 'rename tables' DDL (#5068) #5079
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/run-dm-compatibility-test |
/run-leak-test |
/run-all-tests |
/run-leak-test |
/run-leak-test |
/run-kafka-integration-test |
/run-all-tests |
This is an automated cherry-pick of #5068
What problem does this PR solve?
Issue Number: close #5059
What is changed and how it works?
current ‘rename tables’ dealing logic don't set the snap.currentTs which will result in using the wrong snapshot for DML construction.
So don't return directly for 'rename tables' DDL logic in schema_storge.go:handleDDL,
ref:
tiflow/cdc/entry/schema_storage.go
Line 606 in fffe5a1
Check List
Tests
Related changes
Release note