Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schema(cdc): fix DML construct error caused by 'rename tables' DDL (#5068) #5079

Merged

Conversation

ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Mar 30, 2022

This is an automated cherry-pick of #5068

What problem does this PR solve?

Issue Number: close #5059

What is changed and how it works?

current ‘rename tables’ dealing logic don't set the snap.currentTs which will result in using the wrong snapshot for DML construction.

So don't return directly for 'rename tables' DDL logic in schema_storge.go:handleDDL,
ref:

return s.renameTables(job)

Check List

Tests

  • Unit test
  • Integration test

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to update key monitor metrics in both TiCDC document and official document

Release note

fix DML construct error issue caused by `rename tables` DDL.

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved The current cherry-pick pull request has not been approved and cannot be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Mar 30, 2022
@ti-chi-bot ti-chi-bot added area/ticdc Issues or PRs related to TiCDC. component/ddl DDL component. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-5.4 This PR is cherry-picked to release-5.4 from a source PR. labels Mar 30, 2022
@maxshuang
Copy link
Contributor

/run-dm-compatibility-test
/run-dm-integration-test
/run-kafka-integration-test
/run-integration-test

@maxshuang
Copy link
Contributor

/run-leak-test

@VelocityLight VelocityLight removed the do-not-merge/cherry-pick-not-approved The current cherry-pick pull request has not been approved and cannot be merged. label Apr 20, 2022
@ti-chi-bot ti-chi-bot added the do-not-merge/cherry-pick-not-approved The current cherry-pick pull request has not been approved and cannot be merged. label Apr 20, 2022
@VelocityLight VelocityLight added the cherry-pick-approved Cherry pick PR approved by release team. label Apr 20, 2022
@ti-chi-bot ti-chi-bot removed do-not-merge/cherry-pick-not-approved The current cherry-pick pull request has not been approved and cannot be merged. labels Apr 20, 2022
@maxshuang
Copy link
Contributor

/run-all-tests

@maxshuang
Copy link
Contributor

/run-leak-test
/run-unit-test
/run-verify

@maxshuang
Copy link
Contributor

/run-leak-test
/run-verify

@maxshuang
Copy link
Contributor

/run-kafka-integration-test

@maxshuang
Copy link
Contributor

/run-all-tests

@maxshuang maxshuang added the status/can-merge Indicates a PR has been approved by a committer. label Apr 27, 2022
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Apr 27, 2022
@maxshuang maxshuang merged commit bd9849b into pingcap:release-5.4 Apr 27, 2022
@heibaijian heibaijian added this to the v5.4.1 milestone Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ticdc Issues or PRs related to TiCDC. cherry-pick-approved Cherry pick PR approved by release team. component/ddl DDL component. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-5.4 This PR is cherry-picked to release-5.4 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants