-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sink(ticdc): refine sink interface and add init method (#5196) #5227
sink(ticdc): refine sink interface and add init method (#5196) #5227
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
…5196-to-release-5.4 # Conflicts: # cdc/sink/mq.go
/run-unit-test |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: c481316
|
/run-integration-tests |
@ti-chi-bot: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This is an automated cherry-pick of #5196
What problem does this PR solve?
We need to clean up the old values of the table checkpoint, otherwise when the table is dispatched back again, it may read the old values. See: #4464 (comment).
To guarantee the value is cleared, we clear old values when the table pipeline is created.
Issue Number: close #5197 ref #4464
What is changed and how it works?
refine cdc sink interface
add an init method to init and clear up old values
remove drawback from buffer sink
Check List
Tests
Release note