Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kafka-consumer(ticdc): cherry-pick all changes #5333

Merged
merged 1 commit into from
May 10, 2022
Merged

kafka-consumer(ticdc): cherry-pick all changes #5333

merged 1 commit into from
May 10, 2022

Conversation

hi-rustin
Copy link
Member

@hi-rustin hi-rustin commented May 5, 2022 •
edited

What problem does this PR solve?

Fix flaking tests.

What is changed and how it works?

cherry-pick all changes to kafka-consumer to fix the flaking tests.

Check List

Tests

  • Integration test

Code changes

None

Side effects

None

Related changes

None

Release note 

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 5, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • 3AceShowHand
  • liuzix

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved The current cherry-pick pull request has not been approved and cannot be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 5, 2022
@hi-rustin
Copy link
Member Author

/run-all-tests

@hi-rustin hi-rustin added the area/ticdc Issues or PRs related to TiCDC. label May 5, 2022
@liuzix
Copy link
Contributor

liuzix commented May 5, 2022

/run-kafka-integration-test

@hi-rustin
Copy link
Member Author

/run-kafka-integration-test

passed +1

@hi-rustin
Copy link
Member Author

/run-kafka-integration-test

@hi-rustin
Copy link
Member Author

/run-kafka-integration-test

passed +1

@hi-rustin
Copy link
Member Author

/run-kafka-integration-test

@hi-rustin
Copy link
Member Author

/run-kafka-integration-test

passed +1

@hi-rustin
Copy link
Member Author

/run-kafka-integration-test

@hi-rustin
Copy link
Member Author

/run-kafka-integration-test

passed +1

@hi-rustin
Copy link
Member Author

/run-kafka-integration-test

@hi-rustin
Copy link
Member Author

/run-kafka-integration-test

passed +1

@amyangfei amyangfei added the type/cherry-pick-for-release-5.4 This PR is cherry-picked to release-5.4 from a source PR. label May 6, 2022
@amyangfei amyangfei added this to the v5.4.1 milestone May 6, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 6, 2022
@liuzix
Copy link
Contributor

liuzix commented May 6, 2022

/merge

@ti-chi-bot
Copy link
Member

@liuzix: /merge in this pull request requires 2 approval(s).

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 6, 2022
@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 52e3b9f

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 6, 2022
@zhouqiang-cl zhouqiang-cl added the cherry-pick-approved Cherry pick PR approved by release team. label May 10, 2022
@ti-chi-bot ti-chi-bot removed the do-not-merge/cherry-pick-not-approved The current cherry-pick pull request has not been approved and cannot be merged. label May 10, 2022
@ti-chi-bot ti-chi-bot merged commit dae2d71 into pingcap:release-5.4 May 10, 2022
@heibaijian heibaijian modified the milestones: v5.4.1, v5.4.2 Jun 27, 2022
@hi-rustin hi-rustin deleted the rustin-patch-kafka-consumer-cp branch August 15, 2022 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@3AceShowHand 3AceShowHand 3AceShowHand approved these changes

@liuzix liuzix liuzix approved these changes

Assignees
No one assigned
Labels
area/ticdc Issues or PRs related to TiCDC. cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-5.4 This PR is cherry-picked to release-5.4 from a source PR.
Projects
None yet
Milestone
v5.4.2
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@hi-rustin @ti-chi-bot @liuzix @3AceShowHand @amyangfei @heibaijian @zhouqiang-cl