sink: support to output old value #708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: 5kbpers <tangminghua@pingcap.com>
5kbpers
changed the title
Signed-off-by: 5kbpers <tangminghua@pingcap.com>
Signed-off-by: 5kbpers <tangminghua@pingcap.com>
Signed-off-by: 5kbpers <tangminghua@pingcap.com>
Signed-off-by: 5kbpers <tangminghua@pingcap.com>
Signed-off-by: 5kbpers <tangminghua@pingcap.com>
Signed-off-by: 5kbpers <tangminghua@pingcap.com>
Signed-off-by: 5kbpers <tangminghua@pingcap.com>
|
please resolve the conflicts @5kbpers |
zier-one
reviewed
Jul 27, 2020
amyangfei
reviewed
Jul 27, 2020
amyangfei
reviewed
Jul 27, 2020
Signed-off-by: 5kbpers <tangminghua@pingcap.com>
Signed-off-by: 5kbpers <tangminghua@pingcap.com>
zier-one
reviewed
Jul 29, 2020
amyangfei
reviewed
Jul 30, 2020
amyangfei
reviewed
Jul 30, 2020
pkg/config/sink.go
Outdated
| @@ -17,6 +17,7 @@ package config | |||
| type SinkConfig struct { | |||
| DispatchRules []*DispatchRule `toml:"dispatchers" json:"dispatchers"` | |||
| Protocol string `toml:"protocol" json:"protocol"` | |||
| OldValue bool `toml:"old-value" json:"old-value"` | |||
There was a problem hiding this comment.
Shall we add old-value config to cmd/changefeed.toml now, and add comment to address this is an experimental feature.
|
/run-integration-tests |
|
/run-integration-tests |
amyangfei
added
the
release-blocker
|
/run-integration-tests |
added 2 commits
August 3, 2020 11:26
# Conflicts: # cdc/sink/mysql.go # go.mod # go.sum
|
/run-integration-tests |
|
/run-integration-tests |
Codecov Report
@@ Coverage Diff @@
## master #708 +/- ##
===========================================
Coverage 33.2346% 33.2346%
===========================================
Files 96 96
Lines 11479 11479
===========================================
Hits 3815 3815
Misses 7309 7309
Partials 355 355 |
|
/run-kafka-tests |
|
/run-kafka-tests |
# Conflicts: # cdc/entry/mounter.go
|
/run-all-tests |
|
/lgtm |
ti-srebot
approved these changes
Aug 3, 2020
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: 5kbpers tangminghua@pingcap.com
What problem does this PR solve?
Address a part of #690
Blocked by tikv/tikv#8201
Support to output old value
What is changed and how it works?
Check List
Tests (TODO)
Code changes
Side effects
Related changes
Release note