Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PageFile's meta is broken after we ignore incomplete write batches #1932

Closed
JaySon-Huang opened this issue May 19, 2021 · 0 comments · Fixed by #1934
Closed

PageFile's meta is broken after we ignore incomplete write batches #1932

JaySon-Huang opened this issue May 19, 2021 · 0 comments · Fixed by #1934
Assignees
@JaySon-Huang
Labels
severity/critical type/bug Issue for bug
Projects
Storage Scrum

Comments

@JaySon-Huang
Copy link
Contributor

JaySon-Huang commented May 19, 2021 •
edited

  1. Write some data into PageStorage but not completed
  2. Restore the storage from the disk, it will ignore the incomplete write batch and continue to overwrite data from the current offset that ignore the incomplete write batches

It may leave broken data on PageFile's meta and next time restoring data from disk, it may throw exceptions like "PageFile binary version not match, unknown [version=0] [file=..." or checksum does not match etc...

An issue reported from asktug: https://asktug.com/t/topic/92894
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JaySon-Huang JaySon-Huang

Labels
severity/critical type/bug Issue for bug
Projects
Storage Scrum
Done [Sprint 3]
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix the bug that incomplete write batches are not truncated JaySon-Huang/tiflash
2 participants
@JaySon-Huang @lilinghai