Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop dependency of TiDB for host info #720

Open
breezewish opened this issue Aug 5, 2020 · 2 comments
Open

Drop dependency of TiDB for host info #720

breezewish opened this issue Aug 5, 2020 · 2 comments

Comments

@breezewish
Copy link
Member

Feature Request

Is your feature request related to a problem? Please describe:

Currently host info send queries to TiDB, which has several disadvantages:

  1. The instance list may not be identical with the one in "instance" tab
  2. Doesn't work when there is no TiDB
  3. More potential bugs: A TiDB bug will break the functionality as well, even if original API works well.

Describe the feature you'd like:

Update the host info module to call debug API of each component directly.

Describe alternatives you've considered:

Teachability, Documentation, Adoption, Migration Strategy:

@baurine
Copy link
Collaborator

baurine commented Aug 7, 2020

I didn't find the implemented debug API to get host info in pd/tidb/tikv repos (only found /debug/pprof), so we should implement the API in pd/tidv/tikv first?

@breezewish
Copy link
Member Author

The implementation for TiDB and PD is in https://github.com/pingcap/sysutil.

We can start from dropping the dependency of CLUSTER_INFO table first, then CLUSTER_HARDWARE.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants