Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UCP: Support generating profiling graph without go and pprof #90

Closed
rleungx opened this issue Feb 28, 2020 · 0 comments · Fixed by #328
Closed

UCP: Support generating profiling graph without go and pprof #90

rleungx opened this issue Feb 28, 2020 · 0 comments · Fixed by #328

Comments

@rleungx
Copy link
Member

rleungx commented Feb 28, 2020

Description

Currently, we can get profiling results through API /profile. TiKV will return the file with the extension .svg directly, but go based program such as TiDB and PD will need to use go tool pprof -svg to convert the results to .svg file.

In this case, we need to install go which is too noisy. A possible way to avoid installing go is moving part of code from github.com/google/pprof. Another way is to use driver.PProf, but need to find a way to solve the concurrency problem of output.

Score

  • 2091

Mentor

Recommended Skills

  • Golang
  • Profiling

Learning Materials

@rleungx rleungx self-assigned this Feb 28, 2020
@breezewish breezewish changed the title UCP: Support online profiling UCP: Support generating profiling graph without go and pprof Mar 7, 2020
@breezewish breezewish added this to the 4.0 Post RC Iter W2 milestone Apr 1, 2020
@breezewish breezewish linked a pull request Apr 8, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants