Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openprotocol changed value behavior compatible with new collation #2073

Closed
pepezzzz opened this issue Jun 16, 2021 · 2 comments
Closed

openprotocol changed value behavior compatible with new collation #2073

pepezzzz opened this issue Jun 16, 2021 · 2 comments
Labels
subject/new-feature Denotes an issue or pull request adding a new feature.

Comments

@pepezzzz
Copy link

Feature Request

Is your feature request related to a problem? Please describe:

In the default configuration, the Row Changed Event of TiCDC Open Protocol output in a replication task only contains the changed value, not the value before the change. Therefore, the output value neither supports the new collation framework introduced in TiDB v4.0 .

Enduser already build some flink application handling downstream openprotocol format data with enable-old-value = false. If these applications move to a TiDB cluster downstream with new collation enabled,that will make a compatible issue. Flink application can not deal with the p column properly which comes from enable-old-value , but TiCDC in TiDB cluster with new collation enabled always create enable-old-value task.

Describe the feature you'd like:

the search old value procedure always included by ticdc task,enable-old-value configuration only control the old value output behavior not the search behavior. Then ,this configuration can compatible with new collation.

Describe alternatives you've considered:

Teachability, Documentation, Adoption, Migration Strategy:

@pepezzzz pepezzzz added the subject/new-feature Denotes an issue or pull request adding a new feature. label Jun 16, 2021
@amyangfei
Copy link
Contributor

I'm not quite understand the requirement, do you mean we should add another old-value switch, which can turn on old-value when receiving data from TiKV, and turn off the old-value output field in the open protocol

Besides enable-old-value is controlled in changefeed config, even for a upstream with new CI collation enabled, the old-value feature can be turned off (expect for two scenarios, canal and maxwell will enable old value by default, even the enable-old-value is false in the changefeed config)

@hi-rustin
Copy link
Member

Duplicate of #2301

@hi-rustin hi-rustin marked this as a duplicate of #2301 Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
subject/new-feature Denotes an issue or pull request adding a new feature.
Projects
None yet
Development

No branches or pull requests

3 participants