Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking issue for sink returning inaccurate checkpoints #3545

Closed
9 tasks done
overvenus opened this issue Nov 20, 2021 · 2 comments
Closed
9 tasks done

Tracking issue for sink returning inaccurate checkpoints #3545

overvenus opened this issue Nov 20, 2021 · 2 comments
Assignees
Labels

Comments

@overvenus
Copy link
Member

overvenus commented Nov 20, 2021

In the current implementation (11/20/2021), when a table flushes its' sink, sink may return a checkpoint that is larger than resolved ts.
It can easily be reproduced when tables in a "slow" TiCDC node, whose checkpoint is Tca, are scheduled to a "faster" TiCDC node, whose checkpoint is Tcb, and Tca < Tcb .

Combine with #3029 and #2617, it can easily cause data lose and changefeed stuck when a "slow" is killed, e.g.,

Sink must return accurate checkpoint for each table. It is hard to implement with the current interface design, especially when a sink is shared by multiple tables.

PRs:

@overvenus overvenus added the component/sink Sink component. label Nov 20, 2021
@overvenus overvenus changed the title Tracking issue for sink interface refactor Tracking issue for sink returning inaccurate checkpoints Nov 20, 2021
@overvenus overvenus added severity/major This is a major bug. type/bug This is a bug. labels Nov 20, 2021
@github-actions github-actions bot added this to Need Triage in Question and Bug Reports Nov 20, 2021
@overvenus overvenus added the area/ticdc Issues or PRs related to TiCDC. label Nov 20, 2021
@overvenus overvenus added severity/moderate This is a moderate bug. and removed severity/major This is a major bug. labels Dec 15, 2021
@overvenus
Copy link
Member Author

Change to severity/moderate, as most issues are fixed.

@asddongmen
Copy link
Contributor

@overvenus I think we can close this issue as a result of all the fix PR have been merge.

Question and Bug Reports automation moved this from Need Triage to Done Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

3 participants