Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reuse iterator #1116

Merged
merged 2 commits into from Sep 27, 2016
Merged

reuse iterator #1116

merged 2 commits into from Sep 27, 2016

Conversation

zhangjinpeng87
Copy link
Member

reuse iterator when scan

@zhangjinpeng87
Copy link
Member Author

@BusyJay @disksing PTAL

siddontang
siddontang reviewed Sep 27, 2016
View reviewed changes
src/storage/mvcc/reader.rs
@@ -41,6 +41,10 @@ impl<'a> MvccReader<'a> {
}

pub fn load_data(&mut self, key: &Key, ts: u64) -> Result<Option<Value>> {
if self.used_for_scan {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any test?

@disksing
Copy link
Contributor

LGTM

1 similar comment
@BusyJay
Copy link
Member

BusyJay commented Sep 27, 2016

LGTM

@zhangjinpeng87 zhangjinpeng87 merged commit 4dbf725 into master Sep 27, 2016
@zhangjinpeng87 zhangjinpeng87 deleted the zhangjinpeng/reuse-iterator branch September 27, 2016 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siddontang siddontang siddontang left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zhangjinpeng87 @disksing @BusyJay @siddontang