scheduler: resolve lock by batches. #1271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
siddontang
reviewed
Nov 7, 2016
| } | ||
| } | ||
| } | ||
| let pr = ProcessResult::NextCommand { |
There was a problem hiding this comment.
Will the next rolled back seek the locks from the beginning? If yes, we may skip many tombstone keys.
disksing
changed the title
| locks.push((key.clone(), lock)); | ||
| if let Some(limit) = limit { | ||
| if locks.len() >= limit { | ||
| return Ok((locks, Some(key.append_ts(0)))); |
There was a problem hiding this comment.
To make next batch skip current key.
| b"k1", | ||
| 5); | ||
| } | ||
| store.resolve_lock_ok(5, Some(10)); |
There was a problem hiding this comment.
Rollback is covered by other tests, this is just for testing the batch process works right.
siddontang
reviewed
Nov 7, 2016
| where F: Fn(&Lock) -> bool | ||
| { | ||
| try!(self.create_lock_cursor()); | ||
| let mut cursor = self.lock_cursor.as_mut().unwrap(); | ||
| cursor.seek_to_first(); | ||
| let ok = match start { | ||
| Some(ref x) => try!(cursor.seek(x)), |
There was a problem hiding this comment.
do we have test to cover start key?
There was a problem hiding this comment.
https://github.com/pingcap/tikv/pull/1271/files#diff-a581b51c6f8b34d75b3ce3e7c8037894R494
This test uses different count of locks to test ResolveLock, different values of start should be covered.
|
Please add a description for your PR. |
|
LGTM |
1 similar comment
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve locks by batches to avoid generating a too huge write raft command.