txn: skip constraint check for prewrite when loading data #1411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siddontang
reviewed
Dec 14, 2016
| @@ -408,12 +409,14 @@ impl Storage { | |||
| Ok(()) | |||
| } | |||
|
|
|||
| #[allow(too_many_arguments)] | |||
There was a problem hiding this comment.
need refactor, not allow too_many_arguments directly.
|
LGTM |
|
LGTM |
|
@BusyJay PTAL |
BusyJay
reviewed
Dec 20, 2016
| pub fn prewrite(&mut self, | ||
| mutation: Mutation, | ||
| primary: &[u8], | ||
| lock_ttl: u64, |
There was a problem hiding this comment.
Why not use OptionsArg directly?
| @@ -262,6 +263,23 @@ impl Command { | |||
|
|
|||
| use util::transport::SendCh; | |||
|
|
|||
| #[derive(Default)] | |||
| pub struct OptionalArgs { | |||
There was a problem hiding this comment.
OptionalArgs doesn't seem to be a good name, maybe call it Options or RwOption?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip constraint check for prewrite when loading data.
@siddontang @BusyJay @disksing PTAL