grpc: multi conns to send raft messages. #1921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andelf
reviewed
Jun 12, 2017
src/server/raft_client.rs
Outdated
| .or_insert_with(|| Conn::new(env, addr)) | ||
| } | ||
|
|
||
| pub fn send(&mut self, addr: SocketAddr, msg: RaftMessage) -> Result<()> { | ||
| let index = msg.get_region_id() as usize % self.conn_size; |
There was a problem hiding this comment.
Is this the same as random selection?
There was a problem hiding this comment.
no, to ensure the same region use the same connection
lishuai87
reviewed
Jun 12, 2017
src/server/raft_client.rs
Outdated
| } | ||
|
|
||
| impl RaftClient { | ||
| pub fn new(env: Arc<Environment>) -> RaftClient { | ||
| pub fn new(env: Arc<Environment>, conn_size: usize) -> RaftClient { |
# Conflicts: # etc/config-template.toml # src/bin/tikv-server.rs # src/server/config.rs # src/server/raft_client.rs # src/server/server.rs # tests/raftstore/server.rs
siddontang
reviewed
Jun 13, 2017
etc/config-template.toml
Outdated
| @@ -25,6 +25,8 @@ messages-per-tick = 4096 | |||
| # grpc-concurrency = 2 | |||
| # The number of max concurrent streams/requests on a client connection. | |||
| # grpc-concurrent-stream = 1024 | |||
| # The number of connections to send raft messages. | |||
| # grpc-raft-conn-size = 10 | |||
There was a problem hiding this comment.
size may be not proper here. num may be better.
|
PTAL @javaforfun |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.