snap: delete stale snapshot immediately #2429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI failed |
|
any update @BusyJay |
siddontang
changed the title
|
can we use failpoint for this test now? |
|
I will add a test case once #2474 is merged, which introduces failpoint cases into integration tests. |
BusyJay
changed the title
|
PTAL |
|
LGTM |
|
PTAL @overvenus |
overvenus
reviewed
Nov 20, 2017
src/raftstore/store/worker/region.rs
Outdated
| @@ -109,6 +109,7 @@ impl SnapContext { | |||
| &raw_snap, | |||
| region_id | |||
| )); | |||
| fail_point!("handle_gen", region_id == 1, |_| Ok(())); | |||
There was a problem hiding this comment.
Better adding some comments, I have trouble understanding it.
|
/run-integration-tests |
|
/run-integration-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When replicating a peer, If it splits frequently, its snapshot may be always overlapped with other regions, so the snapshots will never be applied. Unfortunately, GC check can do nothing about the it, because the snapshot is never applied so
compacted_indexis always 0 which is less than any valid snapshot's index. And it's hard to check it in GC too. Because you can't tell if the snapshot is verified to be stale or just still buffered in the channel.So this pr deletes the snapshot files immediately once it fails the snapshot check.